backend: delete dead clients from epoll #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drakulix
force-pushed
the
fix/delete_dead_client
branch
from
6885222
to
2983679
Compare
elinorbgr
requested changes
Jun 25, 2024
Drakulix
force-pushed
the
fix/delete_dead_client
branch
from
2983679
to
4108eea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 73.11% 75.84% +2.72%
==========================================
Files 45 46 +1
Lines 8183 8226 +43
==========================================
+ Hits 5983 6239 +256
+ Misses 2200 1987 -213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
elinorbgr
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure, if we need to do the same thing here for kqueue, I only observed this problem on an epoll system, but I figured it can't hurt.
This fixes a deadlock from killed clients blocking the loop in
dispatch_all_clientsfor the rust-backend.